Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chain-listener): reset proof counters on new epoch in refresh [NET-813] #2246

Merged
merged 1 commit into from
May 14, 2024

Conversation

justprosh
Copy link
Member

Description

Clear proof counters in case of epoch change inside refresh method.

Motivation

Otherwise, in case of websocket disconnect and epoch change peer won't reset proof counters and won't send any proofs.

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@justprosh justprosh requested review from gurinderu and folex May 10, 2024 15:16
Copy link

linear bot commented May 10, 2024

@justprosh justprosh added the e2e Run e2e workflow label May 10, 2024
@justprosh justprosh merged commit da8f4c7 into master May 14, 2024
23 of 24 checks passed
@justprosh justprosh deleted the refresh_epoch_fix branch May 14, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants