Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core-manager): reassignment #2252

Merged
merged 4 commits into from
May 24, 2024
Merged

fix(core-manager): reassignment #2252

merged 4 commits into from
May 24, 2024

Conversation

gurinderu
Copy link
Contributor

@gurinderu gurinderu commented May 21, 2024 •
edited
Loading

Description

Fix the reassignment CPU requirements calculation

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@gurinderu gurinderu added the e2e Run e2e workflow label May 21, 2024
@gurinderu gurinderu marked this pull request as ready for review May 21, 2024 16:12
mikevoronov
mikevoronov approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@mikevoronov mikevoronov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crates/core-manager/src/strict.rs Outdated Show resolved Hide resolved
crates/core-manager/src/strict.rs Outdated Show resolved Hide resolved
gurinderu and others added 2 commits May 24, 2024 14:06
@gurinderu @mikevoronov
Update crates/core-manager/src/strict.rs
e1f21b2 
Co-authored-by: Mike Voronov <michail.vms@gmail.com>
@gurinderu @mikevoronov
Update crates/core-manager/src/strict.rs
ec17fcb 
Co-authored-by: Mike Voronov <michail.vms@gmail.com>
@gurinderu gurinderu enabled auto-merge (squash) May 24, 2024 11:07
@gurinderu gurinderu merged commit d903f2a into master May 24, 2024
14 checks passed
@gurinderu gurinderu deleted the fix-count branch May 24, 2024 11:54
@fluencebot fluencebot mentioned this pull request May 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikevoronov mikevoronov mikevoronov approved these changes

Assignees
No one assigned
Labels
e2e Run e2e workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gurinderu @mikevoronov @justprosh