Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changeable logic for response querying #439

Closed
DieMyst opened this issue Feb 12, 2019 · 4 comments
Closed

Changeable logic for response querying #439

DieMyst opened this issue Feb 12, 2019 · 4 comments
Assignees
Labels
enhancement ~fluence-js component: fluence-js js tech: js
Milestone

Comments

@DieMyst
Copy link
Member

DieMyst commented Feb 12, 2019

  • a client can customize the global timeout for the session
  • exponential backoff on querying after some time
  • add some config for sessions

Querying - periodic check that Tendermint's response is formed

@DieMyst DieMyst added enhancement ~fluence-js component: fluence-js js tech: js labels Feb 12, 2019
@DieMyst DieMyst self-assigned this Feb 12, 2019
@alari alari added this to the !devnet-mp1 milestone Feb 14, 2019
@folex
Copy link
Member

folex commented May 7, 2019

@DieMyst This task was created a while ago, could you please check that this issue is still relevant, and maybe actualize its description? I remember we had a few thoughts about websocket transport, wouldn't it supersede this task?

@DieMyst
Copy link
Member Author

DieMyst commented May 7, 2019

This is relevant and is not superseded by web sockets. We will support the HTTP protocol as well. And cannot use only push-from-server model in web sockets. Querying result process should remain because of these reasons.

This issue is about:

  • not to DDOS Fluence nodes if there is a lot of requests
  • stop querying if there is no response for some time
  • additionally: add queue for querying responses

@folex
Copy link
Member

folex commented May 7, 2019

Seems like this issue could be split into several separate issues.

not to DDOS Fluence nodes if there is a lot of requests

  1. An improvement in Fluence JS library - exponential backoff

stop querying if there is no response for some time

Seems like it would be implemented in #638

additionally: add queue for querying responses

This is, too, an improvement in Fluence JS library? Or should that queue be on the Node/Statemachine side?

And original points:

a client can customize the global timeout for the session

Is this about client giving up too early on transaction? Not sure what timeout is meant here

add some config for sessions

Also not sure which config is meant here. Can you clarify, please?

@folex
Copy link
Member

folex commented May 7, 2019

Closing this as superseded by the above tasks.

@folex folex closed this as completed May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ~fluence-js component: fluence-js js tech: js
Projects
None yet
Development

No branches or pull requests

3 participants