feat(spells): support empty trigger configs [NET-316] #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An empty trigger config is used either to unsubscribe a spell from triggers or to not subscribe at all if it was used on installation. Also remove updating interface inside the spell-event-bus, since it's not needed.
kmd-fl
changed the title
folex
reviewed
Jan 17, 2023
| #[test] | ||
| fn spell_update_config() { | ||
| let swarms = make_swarms(1); | ||
| //log_utils::enable_logs(); |
There was a problem hiding this comment.
Suggested change
| //log_utils::enable_logs(); |
kmd-fl
commented
Jan 17, 2023
| )"#, | ||
| client.peer_id | ||
| ); | ||
| // create periodic spell |
There was a problem hiding this comment.
Suggested change
| // create periodic spell |
folex
reviewed
Jan 17, 2023
| #[test] | ||
| fn spell_update_config_stopped_spell() { | ||
| let swarms = make_swarms(1); | ||
| //log_utils::enable_logs(); |
There was a problem hiding this comment.
Suggested change
| //log_utils::enable_logs(); |
folex
reviewed
Jan 17, 2023
| .wrap_err("connect client") | ||
| .unwrap(); | ||
|
|
||
| // Create spell that do nothing. |
There was a problem hiding this comment.
Suggested change
| // Create spell that do nothing. | |
| // Create a spell that does nothing. |
folex
reviewed
Jan 17, 2023
| } | ||
| was_removed |
folex
reviewed
Jan 17, 2023
Comment on lines
-139
to
-147
| let new_len = self.scheduled.len(); | ||
| let removed = self.subscribers.remove(spell_id); | ||
| prev_len != new_len || removed | ||
| } | ||
|
|
||
| fn update(&mut self, spell_id: &SpellId, config: &SpellTriggerConfigs) { | ||
| if self.unsubscribe(spell_id) { | ||
| self.subscribe(spell_id.clone(), config); | ||
| } |
folex
reviewed
Jan 17, 2023
sorcerer/src/spells.rs
Outdated
| ))); | ||
| } | ||
| } else { | ||
| log::trace!("empty config given for spell {}", spell_id); |
There was a problem hiding this comment.
can you include particle_id in this log please? I think one day we might want to see this message when debugging spell installation
folex
approved these changes
Jan 17, 2023
justprosh
approved these changes
Jan 18, 2023
folex
approved these changes
Jan 18, 2023
Co-authored-by: Aleksey Proshutisnkiy <justprosh@users.noreply.github.com>
kmd-fl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An empty trigger config allows:
Also, remove the update interface from the spell-event-bus crate since all it needs to do is expressed via subscribe/unsubscribe methods.