feat(spells): do json manipulations internally #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folex
reviewed
Jan 26, 2023
| @@ -66,7 +66,7 @@ pub(crate) async fn spell_install( | |||
| services.call_function( | |||
| &spell_id, | |||
| "set_json_fields", | |||
| vec![json!(init_data)], | |||
| vec![json!(init_data.to_string())], | |||
There was a problem hiding this comment.
shouldn't it be enough to pass init_data.to_string()? If not, why not?
There was a problem hiding this comment.
call_function accepts function_args: Vec<JValue>
folex
reviewed
Jan 26, 2023
| process_func_outcome::<UnitValue>( | ||
| services.call_function( | ||
| spell_id, | ||
| "set_json_fields", | ||
| args.function_args.clone(), | ||
| vec![json!(response.to_string())], |
There was a problem hiding this comment.
same thing, why do you serialize it to json twice?
There was a problem hiding this comment.
set_json_fields accepts string that can be parsed to json
There was a problem hiding this comment.
response.to_string() seems to satisfy that description
There was a problem hiding this comment.
yeah, but call_function accepts function_args: Vec<JValue>
folex
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getDataSrvreturns parsed json value, so there is no need to parse it manuallyspell.installnow accepts any object asinit_data(previously, it was accepting only stringified ones)responseaccepts objects (previously, it was accepting only stringified ones)