feat(libp2p): Optional async std libp2p & profiling profile #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurinderu
force-pushed
the
optional-async-std-libp2p
branch
4 times, most recently
from
c04b27a
to
7b5e71c
Compare
gurinderu
force-pushed
the
optional-async-std-libp2p
branch
from
9426802
to
db73537
Compare
gurinderu
changed the title
gurinderu
force-pushed
the
optional-async-std-libp2p
branch
from
db73537
to
f16b088
Compare
gurinderu
changed the title
folex
reviewed
Feb 13, 2023
.github/workflows/snapshot.yml
Outdated
| @@ -59,11 +59,11 @@ jobs: | |||
| publish: false | |||
|
|
|||
| - name: Run cargo build | |||
| run: cargo build --release -p particle-node | |||
| run: cargo build --profile release-with-debug -p particle-node | |||
There was a problem hiding this comment.
I'm not sure we want that for every snapshot. WDYT?
There was a problem hiding this comment.
For dev purposes, it is extremely useful. You can debug and profile these images.
There was a problem hiding this comment.
With this approach, we loose non-dev snapshots for the branch.
These snapshots are used in three ways:
- in e2e tests, where these snapshots must be fast
- to deploy temporary fixes to our environments, even to kras, and it must be fast there
- profiling - pretty rare thing
To me, it seems that profile-able images are better to be ran on request. Maybe manually changing profile to profiling (aka release-with-debug) in CI scripts is a good-enough approach.
If we choose that path, then I'd keep profile in Cargo.toml, but rename it to profiling.
folex
approved these changes
Feb 13, 2023
folex
changed the title
gurinderu
force-pushed
the
optional-async-std-libp2p
branch
from
4764563
to
94a63d5
Compare
gurinderu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.