feat(sig): sig use worker keypair if called in worker scope [NET-371] #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justprosh
changed the title
justprosh
force-pushed
the
worker_sig
branch
from
acc72bf
to
fe9bfbd
Compare
kmd-fl
reviewed
Feb 13, 2023
justprosh
changed the title
justprosh
commented
Feb 14, 2023
folex
reviewed
Feb 14, 2023
particle-builtins/src/builtins.rs
Outdated
Comment on lines
910
to
913
| if (t.service_id.as_str(), t.function_name.as_str()) | ||
| != ("registry", "get_record_bytes") | ||
| && (t.service_id.as_str(), t.function_name.as_str()) | ||
| != ("registry", "get_record_metadata_bytes") |
There was a problem hiding this comment.
Suggested change
| if (t.service_id.as_str(), t.function_name.as_str()) | |
| != ("registry", "get_record_bytes") | |
| && (t.service_id.as_str(), t.function_name.as_str()) | |
| != ("registry", "get_record_metadata_bytes") | |
| let duplet = (t.service_id.as_str(), t.function_name.as_str()); | |
| let metadata_bytes = ("registry", "get_record_metadata_bytes"); | |
| let record_bytes = ("registry", "get_record_bytes"); | |
| if duplet != record_bytes && duplet != metadata_bytes |
folex
approved these changes
Feb 14, 2023
justprosh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.