Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(builtins): impl srv.info, dist.get_blueprint #1468

Merged
merged 7 commits into from
Feb 15, 2023

Conversation

folex
Copy link
Member

@folex folex commented Feb 15, 2023

No description provided.

@folex folex requested a review from justprosh February 15, 2023 11:38
@folex folex marked this pull request as ready for review February 15, 2023 11:39
@@ -187,6 +187,30 @@ impl ParticleAppServices {
Ok(service_id)
}

pub fn get_service_info(
&self,
worker_id: PeerId,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mb rename it to worker_peer_id?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we call it worker_id everywhere, and there's no other id except peer id

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between this worker_id and service.worker_id? I though service.worker_id is a service/spell id of a worker, no?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no difference. service.worker_id indicates where is this service deployed

Copy link
Member Author

@folex folex Feb 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's the same thing. Services now can belong to worker_id, aka virtual peer.

service.worker_id is the PeerId of the worker aka virtual peer, same for worker_id

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we start using the word "worker" (which isn't descriptive at all) and not "virtual peer" (which is self-explanatory) then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because worker comes from deals and is more workload and user-oriented. computation worker.

virtual peer is just some shenanigan inside rust-peer. it builds off the concept of peers. and it doesn't tell anything about computation or services. in other words, virtual peer is just one of the many pieces that make worker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants