Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend peer identify with spell service version and allowed mounted binaries list [fixes NET-429 NET-381] #1540

Merged
merged 9 commits into from
Mar 31, 2023

Conversation

kmd-fl
Copy link
Contributor

@kmd-fl kmd-fl commented Mar 29, 2023

Extend Peer.identify

  • add list of allowed_binaries
  • add spell_version

Looks like this

{
  "air_version": "0.38.0",
  "allowed_binaries": [
    "/usr/bin/ipfs",
    "/usr/bin/curl"
  ],
  "external_addresses": [],
  "node_version": "0.9.1",
  "spell_version": "0.5.6"
}

Spell version is determent as follows:

  1. If it's loaded from crate, the crate version is in use.
  2. If it's loaded from disk, version is in the format wasm hashes <hash1[..8]> <hash2[..8]> with first 8 symbols of each hash.

To do this, I needed to move Peer.identify implementation from builtins to the sorcerer. Can't say I like it very much, but it works.

sorcerer/src/sorcerer.rs Outdated Show resolved Hide resolved
@kmd-fl kmd-fl changed the title feat: extend peer identify with spell service version and allowed mounted binaries list feat: extend peer identify with spell service version and allowed mounted binaries list [fixes NET-429 NET-381] Mar 31, 2023
@linear
Copy link

linear bot commented Mar 31, 2023

@kmd-fl kmd-fl requested a review from folex March 31, 2023 10:12
@kmd-fl kmd-fl added the e2e Run e2e workflow label Mar 31, 2023
particle-node/src/node.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants