-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extend peer identify with spell service version and allowed mounted binaries list [fixes NET-429 NET-381] #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folex
reviewed
Mar 30, 2023
folex
approved these changes
Mar 30, 2023
kmd-fl
changed the title
feat: extend peer identify with spell service version and allowed mounted binaries list
feat: extend peer identify with spell service version and allowed mounted binaries list [fixes NET-429 NET-381]
Mar 31, 2023
NET-429 provide API to list available mounted binaries NET-381 Add Spell Service version to node info in `Peer.identify`
To easily track spells and find compatibility issues |
justprosh
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend
Peer.identify
allowed_binaries
spell_version
Looks like this
Spell version is determent as follows:
wasm hashes <hash1[..8]> <hash2[..8]>
with first 8 symbols of each hash.To do this, I needed to move
Peer.identify
implementation from builtins to the sorcerer. Can't say I like it very much, but it works.