fix(metrics): collect metrics for custom services [fixes NET-438] #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmd-fl
changed the title
NET-438 Collect builtin metrics for Custom Services
Essentially, custom services are builtins, but metrics for them aren't collected. |
folex
approved these changes
Apr 4, 2023
kmd-fl
force-pushed
the
custom-service-metrics
branch
from
3b4708e
to
9b7058e
Compare
justprosh
approved these changes
Apr 6, 2023
| @@ -15,7 +15,7 @@ use crate::services_metrics::message::ServiceCallStats; | |||
| type ServiceId = String; | |||
| type Name = String; | |||
|
|
|||
| /// Store a part of series of numeric observations and some parameters that desribe the series. | |||
| /// Store a part of series of numeric observations and some parameters that describes the series. | |||
There was a problem hiding this comment.
Suggested change
| /// Store a part of series of numeric observations and some parameters that describes the series. | |
| /// Store a part of series of numeric observations and some parameters that describe the series. |
"parameters" is plural
particle-builtins/src/builtins.rs
Outdated
Comment on lines
142
to
149
| let result = self.builtins_call(args, particle).await; | ||
| let result = match result { | ||
| FunctionOutcome::NotDefined { args, params } => { | ||
| self.custom_service_call(args, params).await | ||
| } | ||
| result => result, | ||
| }; | ||
| let end = start.elapsed().as_secs(); |
There was a problem hiding this comment.
So it measures builtin+custom service calls?
There was a problem hiding this comment.
Yeah, I think the time needed for ensuring the service call isn't in the builtins list isn't significant.
Probrably, can do smth like
let mut start = ...;
....
FunctionOutcome::NotDefined { args, params } => {
start = Instant::now();
self.custom_service_call(args, params).await
}
...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.