Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(logging): add structured fields in logging + new log format #1590

Merged
merged 6 commits into from
Apr 27, 2023
Merged

feat(logging): add structured fields in logging + new log format #1590

merged 6 commits into from
Apr 27, 2023

Conversation

gurinderu
Copy link
Contributor

@gurinderu gurinderu commented Apr 25, 2023 •
edited
Loading

Description

Added particle_id label for the structured logging
Added configuration for the log format

@gurinderu gurinderu marked this pull request as ready for review April 25, 2023 14:10
@gurinderu gurinderu changed the title feat(logging): add structured fields in logging feat(logging): add structured fields in logging + new log format Apr 26, 2023
@gurinderu gurinderu force-pushed the improve_logging branch 3 times, most recently from dfb70cd to d2df096 Compare April 27, 2023 10:48
@gurinderu gurinderu added the e2e Run e2e workflow label Apr 27, 2023
kmd-fl
kmd-fl reviewed Apr 27, 2023
View reviewed changes
aquamarine/src/particle_functions.rs Outdated Show resolved Hide resolved
connection-pool/src/behaviour.rs Outdated Show resolved Hide resolved
crates/server-config/src/defaults.rs Show resolved Hide resolved
crates/server-config/src/resolved_config.rs Show resolved Hide resolved
particle-node/src/dispatcher.rs Outdated Show resolved Hide resolved
gurinderu and others added 3 commits April 27, 2023 18:37
@gurinderu @folex
Update particle-node/src/connectivity.rs
809851d 
Co-authored-by: folex <0xdxdy@gmail.com>
@gurinderu @folex
Update particle-node/src/connectivity.rs
97ad779 
Co-authored-by: folex <0xdxdy@gmail.com>
@gurinderu @folex
Update particle-node/src/connectivity.rs
770818c 
Co-authored-by: folex <0xdxdy@gmail.com>
@folex folex merged commit 0c06f1b into master Apr 27, 2023
@folex folex deleted the improve_logging branch April 27, 2023 16:20
@fluencebot fluencebot mentioned this pull request Apr 27, 2023
Merged
@fluencebot fluencebot mentioned this pull request Jun 22, 2023
Merged
@fluencebot fluencebot mentioned this pull request Jul 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@folex folex folex approved these changes

@kmd-fl kmd-fl kmd-fl approved these changes

@justprosh justprosh Awaiting requested review from justprosh

Assignees
No one assigned
Labels
e2e Run e2e workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gurinderu @folex @kmd-fl