-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dist)!: make blueprint an IPLD, use CID as module ids [NET-412 NET-432] #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folex
reviewed
May 3, 2023
NET-432 CID[IPLD]-fication of blueprints NET-412 Use CIDs for blueprint ids
Right now it is some blake-something hash and it is impossible to compare CID to blueprint id |
kmd-fl
reviewed
May 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it mean that aqua deploy_service
/fluence workers deploy
will stop working properly?
folex
reviewed
May 16, 2023
folex
reviewed
May 16, 2023
folex
reviewed
May 16, 2023
folex
reviewed
May 16, 2023
folex
reviewed
May 16, 2023
folex
reviewed
May 16, 2023
folex
reviewed
May 16, 2023
folex
reviewed
May 16, 2023
folex
reviewed
May 16, 2023
folex
reviewed
May 16, 2023
folex
reviewed
May 16, 2023
folex
reviewed
May 16, 2023
folex
reviewed
May 16, 2023
folex
reviewed
May 16, 2023
folex
reviewed
May 16, 2023
folex
approved these changes
May 16, 2023
folex
reviewed
May 18, 2023
folex
reviewed
May 18, 2023
folex
reviewed
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the blueprint looked like this:
Module IDs were represented as blake3 hashes. Modules could also be specified by names, which were local to each peer and could be easily overwritten. The blueprint ID was a blake3 hash of the dependencies.
In deals, we already use CIDs for modules and worker definitions, which can be seen as a combination of service blueprints and spell definitions.
This PR contains the next BREAKING CHANGES:
dist.make_blueprint
returns a string representing the blueprint in IPLD format, which can be directly added to IPFS usingipfs dag put
. This ensures the same CID is used everywhere.The updated blueprint now looks like this:
Blueprint now looks like this:
The strings bafybeieh62qys3ln2qiqbye2jgynxkfzzlvebw7dtpsqgv45p6qw62hk7u and bafybeigrqdxshsoxwp27s47tr3inn6pkt3ggh7hzwcqz7qgfrxmw3j77vu are the CIDs of the respective modules.