Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): correctly parse env variables #1607

Merged
merged 4 commits into from
May 6, 2023
Merged

fix(config): correctly parse env variables #1607

merged 4 commits into from
May 6, 2023

Conversation

folex
Copy link
Member

@folex folex commented May 6, 2023

Before, they were split by _, which caused the following parsing behaviour:

[crates/server-config/src/resolved_config.rs:212] config_builder.extract()? = {
    "print_config": Bool(false),
    "aqua_pool_size": String("6"),
    "env": Object {
        "aqua": Object {
            "ipfs": Object {
                "external": Object {
                    "api": Object {
                        "multiaddr": String("/ip4/127.0.0.1/tcp/5001"),
                    },
                },
                "local": Object {
                    "api": Object {
                        "multiaddr": String("/ip4/127.0.0.1/tcp/5001"),
                    },
                },
            },
        },
    },
    "allowed": Object {
        "binaries": Array [
            String("azaza"),
        ],
    },
    "local": Bool(true),
    "no_banner": Bool(false),
    "allow_local_addresses": Bool(false),
}

@folex folex requested a review from gurinderu May 6, 2023 16:05
@folex folex added the e2e Run e2e workflow label May 6, 2023
@folex folex enabled auto-merge (squash) May 6, 2023 16:22
@folex folex merged commit 2f77e04 into master May 6, 2023
23 checks passed
@folex folex deleted the fix_env_args branch May 6, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants