Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config)!: Introduce tracing config, change allowed_binaries list format #1608

Merged
merged 7 commits into from
May 16, 2023
Merged

feat(config)!: Introduce tracing config, change allowed_binaries list format #1608

merged 7 commits into from
May 16, 2023

Conversation

gurinderu
Copy link
Contributor

@gurinderu gurinderu commented May 10, 2023 •
edited
Loading

Description

  • Added tracing config
  • Changed a config library because of bad error messaging
  • Changed a key separator for envs from _ to __
  • Changed a list format (ie FLUENCE__ALLOWED_BINARIES = "/bin/sh, /bin/bash" instead of "["/bin/sh","/bin/bash"]"

@linear
Copy link

linear bot commented May 10, 2023

NET-471 Minor config fixes + tracing config

@gurinderu gurinderu changed the title feature(config): Tracing config feat(config): Tracing config May 10, 2023
@gurinderu gurinderu marked this pull request as ready for review May 10, 2023 17:13
@gurinderu gurinderu added the e2e Run e2e workflow label May 10, 2023
@gurinderu gurinderu added e2e Run e2e workflow and removed e2e Run e2e workflow labels May 11, 2023
@kmd-fl
Copy link
Contributor

kmd-fl commented May 11, 2023 •
edited
Loading

What does "tracing config" mean? What does it do? @gurinderu

@gurinderu
Copy link
Contributor Author

What does "tracing config" mean? What does it do? @gurinderu

It is a configuration for the opentelemetry collector

@folex folex changed the title feat(config): Tracing config feat(config)!: Introduce tracing config, change allowed_binaries list format May 15, 2023
@folex folex merged commit 6f7c684 into master May 16, 2023
17 checks passed
@folex folex deleted the feature/net-471 branch May 16, 2023 00:02
@fluencebot fluencebot mentioned this pull request May 16, 2023
Merged
@fluencebot fluencebot mentioned this pull request Jun 22, 2023
Merged
@fluencebot fluencebot mentioned this pull request Jul 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@folex folex folex approved these changes

@justprosh justprosh Awaiting requested review from justprosh

@kmd-fl kmd-fl Awaiting requested review from kmd-fl

Assignees
No one assigned
Labels
e2e Run e2e workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gurinderu @kmd-fl @folex