Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please stop to use apt-key for install documentation #472

Closed
kenhys opened this issue Feb 21, 2021 · 3 comments
Closed

Please stop to use apt-key for install documentation #472

kenhys opened this issue Feb 21, 2021 · 3 comments
Labels

Comments

@kenhys
Copy link
Contributor

kenhys commented Feb 21, 2021

Problem

Deprecated apt-key command is used to import key.
apt-key command will be removed sooner or later.

Actual

https://github.com/fluent/fluent-bit-docs/blob/master/installation/linux/debian.md#server-gpg-key

$ wget -qO - https://packages.fluentbit.io/fluentbit.key | sudo apt-key add -

Expected

Convert key to keyring and refer it by signed-by for example.

sudo apt-key --keyring ./fluent-bit-archive-keyring.gpg add fluentbit.key
$ cat /etc/apt/sources.list.d/fluent-bit.list 
deb [signed-by=/usr/share/keyrings/fluent-bit-archive-keyring.gpg] https://packages.fluentbit.io/debian/buster buster main
@agup006
Copy link
Member

agup006 commented Feb 25, 2021

Thanks for reporting @kenhys, I also feel we should mimic Fluentd all-in-one.sh script for installation. Perhaps in that installation script we can change the way keys are installed

@patrick-stephens
Copy link
Contributor

@agup006 want me to look at this more generally for packaging? I've added repo config files as well for the Yum-style repos so rather than creating a file you can just download it.

@github-actions
Copy link

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days. Maintainers can add the exempt-stale label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants