Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Missing build args in fluentd docker image #1094

Closed
sarathchandra24 opened this issue Mar 15, 2024 · 1 comment · Fixed by #1095
Closed

bug: Missing build args in fluentd docker image #1094

sarathchandra24 opened this issue Mar 15, 2024 · 1 comment · Fixed by #1095
Assignees

Comments

@sarathchandra24
Copy link
Collaborator

Describe the issue

As per the #1079 this should have been a tagged build and deployment, but somehow a file change was missing when I made the commit that doesn't uses any run time tags.

As per https://github.com/fluent/fluent-operator/blob/master/.github/workflows/build-fd-image.yaml#L276-L278, if we observe here these build args being passed but not utilized by the image.

To Reproduce

N/A - Not an issue currently but a feature to improve

Expected behavior

Should pass:

ARG BASE_IMAGE=kubesphere/fluentd
ARG BASE_IMAGE_TAG=latest-arm64-base

and utilize it here

FROM ${BASE_IMAGE}:${BASE_IMAGE_TAG}
LABEL Description="Fluentd docker image" Vendor="Fluent Organization" Version=${BASE_IMAGE_TAG}
ENV TINI_VERSION=0.18.0

Your Environment

- Fluent Operator version:
- Container Runtime: Docker 
- Operating system: MacOS 14.3.1 
- Kernel version: Darwin 23.3.0

How did you install fluent operator?

No response

Additional context

No response

@sarathchandra24
Copy link
Collaborator Author

Creating a PR for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant