Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default s3_object_key_format is racy with multi workers #391

Closed
daipom opened this issue Mar 8, 2022 · 1 comment
Closed

The default s3_object_key_format is racy with multi workers #391

daipom opened this issue Mar 8, 2022 · 1 comment

Comments

@daipom
Copy link
Contributor

daipom commented Mar 8, 2022

Is your feature request related to a problem? Please describe.

I assume the same problem could occur in multi-workers as #326, although I have not confirmed the problem.

In #326, multi-threading with flush_thread_count is discussed,
but I think the same problem exists when running with multiple workers.

Describe the solution you'd like

In #327, the warning was added for the case of multi-threading with flush_thread_count.
So we need to add the same warning for the case of multi-workers.

Describe alternatives you've considered

None.

Additional context

No response

@fujimotos fujimotos changed the title The default s3_object_key_format is not thread safe in multi workers The default s3_object_key_format is racy with multi workers Mar 10, 2022
@daipom
Copy link
Contributor Author

daipom commented Mar 11, 2022

#392 is merged, so I close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant