Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out kubernetes config file #531

Closed
GerkinDev opened this issue Feb 4, 2021 · 2 comments · Fixed by #534
Closed

Split out kubernetes config file #531

GerkinDev opened this issue Feb 4, 2021 · 2 comments · Fixed by #534

Comments

@GerkinDev
Copy link
Contributor

Hi!

For ease of maintenance and customization, it would be great to have multiple config files, one for each type of kubernetes log. In fact, in my situation, I have to override the parser for audit log (see #519), but still rely on default config for the others.

Would you welcome such refactor?
Moreover, this could be a non-breaking change I guess, because this would be feasible to change the main kubernetes.conf file as an includer of each sub-file. So, if it is replaced, new includes would be omitted.

In a longer sight, this would allow more souple configuration from env. Something like this in kubernetes.conf

include "kubernetes-audit-#{ENV['FLUENT_KUBERNETES_AUDIT_MODE'] ||"legacy"}.conf
@repeatedly
Copy link
Member

Looks good for me. Could you send a patch?

@GerkinDev
Copy link
Contributor Author

I'll soon open a pr with this ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants