Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in_tail bug with read_lines_limit #2477

Closed
metayd opened this issue Jul 3, 2019 · 1 comment
Closed

in_tail bug with read_lines_limit #2477

metayd opened this issue Jul 3, 2019 · 1 comment
Labels
bug

Comments

@metayd
Copy link

metayd commented Jul 3, 2019

Check CONTRIBUTING guideline first and here is the list to help us investigate the problem.

Describe the bug
Should it be read_more = false rather than read_more = true at https://github.com/fluent/fluentd/blob/master/lib/fluent/plugin/in_tail.rb#L741 ?
@metayd metayd added the bug label Jul 3, 2019
@repeatedly
Copy link
Member

repeatedly commented Jul 3, 2019 •
edited

No. these lines are emitted after break so no problem. read_more becomes false when buffer/output can't process incoming traffic from input to stop reading data.

@metayd metayd mentioned this issue Jul 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@repeatedly @metayd