Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowering log level of "chunk bytes limit exceeds for an emitted event stream" logs to trace #4177

Open
raytung opened this issue May 15, 2023 · 1 comment

Comments

@raytung
Copy link
Member

raytung commented May 15, 2023

Is your feature request related to a problem? Please describe.

Hey team 馃憢

From what I have gathered, fluentd did not split chunks if the event stream exceeds the chunk bytes limit, but this was changed in b5f2e9f.
Since we are now splitting chunks and retrying the chunks, I think this log (chunk bytes limit exceeds for an emitted event stream) is now more informational (and for debugging really) more than indicative of a potential issue.

Describe the solution you'd like

What are your thoughts on lowering this log line from warn to something like trace?

Describe alternatives you've considered

Leaving it - but it does generate a lot of logs

Additional context

No response

@daipom
Copy link
Contributor

daipom commented May 15, 2023

I don't immediately get the meaning of the condition format && empty_chunk for this warning message.
I guess it is important what this condition is for.

if format && empty_chunk
if chunk.bytesize > @chunk_limit_size
log.warn "chunk bytes limit exceeds for an emitted event stream: #{adding_bytesize}bytes"
else
log.warn "chunk size limit exceeds for an emitted event stream: #{chunk.size}records"
end
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants