Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should().Equals(object) should not be used #120

Closed
Corniel opened this issue Nov 17, 2021 · 4 comments
Closed

Should().Equals(object) should not be used #120

Corniel opened this issue Nov 17, 2021 · 4 comments

Comments

@Corniel
Copy link

Corniel commented Nov 17, 2021

Equals does no do what people might think.

See: https://community.sonarsource.com/t/fluentassertion-should-and-equals-methods-shouldnt-be-used-together/38181
@Meir017
Copy link
Member

Meir017 commented Nov 17, 2021

@Corniel hasn't this been handled in #95 ?

@Corniel
Copy link
Author

Corniel commented Nov 17, 2021

@Meir017 I can test that. Both ways, you should advocate there I think. :)

@Meir017
Copy link
Member

Meir017 commented Nov 29, 2021

@Corniel that's exactly what the analyzer + code-fixer suggest here. basically never use Equals with fluent-assertions

@Corniel
Copy link
Author

Corniel commented Nov 29, 2021

Thanx,. I'll report that.

@Corniel Corniel closed this as completed Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Corniel @Meir017