-
-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Faqt link to docs #2299
Comments
@jnyrup I'm fine with this, but what about you? |
As long as it isn't formulated as we don't have any support at all for F# (because that is not true) I'm absolute fine with adding docs. I imagine that page could evolve into something like:
|
How do you feel about the suggested wording in the first post above? (See the quoted section.) I think it satisfies your requirement. |
I think the wording is too harsh on FluentAssertions. The linked issue we deemed out of scope because the suggestion of doubling the API surface is only necessary for F#. So I think the wording should focus more on where using FA becomes clunky for F# users and where Faqt improves on that. |
Sure, I'm happy to accommodate your input! Below is a revised suggestion that removes the general "out of scope" message (it limits it to the F# usageWe encourage F# developers to try out Faqt, an assertion library inspired by FluentAssertions and made specifically for F#. FluentAssertions is made with C# in mind. While it can be used from F#, the experience will not be as intended. In particular:
|
Much better ❤️ |
I have been working with F# full-time for more than five years now and consider myself an experienced and fairly advanced F# programmer, and I respectfully and completely disagree. Fluent syntax is fantastic, also in F#, at least for DLSs like this. The discoverability is great since you can just type a dot to discover methods; the ability to overload methods is a nice convenience that can reduce verbosity; and it's just as concise as piping (in fact more so, since you don't have to prefix everything with a module name, which is often done when piping). I made Faqt precisely because no other assertion framework (when used from F#) came close to the same convenience, discoverability, readability, and extensibility. I have also used fluent syntax in other libraries/frameworks I have created, such as Facil and Felicity, and none of the comments/issues posted to these repos have voiced any dissatisfaction with the basic fluent syntax. |
@jnyrup As I understand it, my proposed text can be used. If you let me know which files to change/create and where, I can make a PR. 🙂 |
It is at least close enough that any last details might as well be discussed in a PR. The individual pages are located in https://github.com/fluentassertions/fluentassertions/tree/develop/docs/_pages |
Great, I'll try to look at it on Monday! |
@cmeeren then your experience is different from mine, which is totally fine :-) |
Background and motivation
Continuing from #2225 (comment) and subsequent comments.
Since F# support is deemed out of scope, I am wondering if you are open to linking to Faqt. I imagine this could be done simply by adding a new page to the menu called "F# usage", around here:
On that page, we could have something like this:
If you want me to submit a PR, please let me know approximately where I need to change things, and I'll jump on it.
Alternative Concerns
No response
Are you willing help with a pull-request?
Yes, please assign this issue to me.
The text was updated successfully, but these errors were encountered: