Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Runner without dependencies to other database types #1323

Closed
oivindth opened this issue Aug 24, 2020 · 7 comments
Closed

Adding Runner without dependencies to other database types #1323

oivindth opened this issue Aug 24, 2020 · 7 comments
Milestone

Comments

@oivindth
Copy link

It should be possible to add migration runner without adding dependencies to other database types.

Can AddFluentMigratorCore() and IMigrationRunner be moved to FluentMigrator.Runner.Core package so that I can add Runner.Core package instead of Runner package which has all the db dependencies?

@jzabroski
Copy link
Collaborator

Hi @oivindth , there is an open PR for this concept. #1198 . I haven't given it much attention because I've been doing a lot of "product management" type work after taking over the project from @fubar-coder .

I think it should be possible to do as you suggest. The main blocking ticket is for me to finish up #1178 and merge the 4.0 branch with the 3.0 branch (75% done).

@jzabroski
Copy link
Collaborator

I did an initial review of @gliljas #1198 PR this morning. My synopsis is here; #1198 (review)

@brendonparker
Copy link

I agree, this would be nice.

In the meantime, does anyone know of a workaround. Adding a dependency to FluentMigrator.Runner adds entirely too much dll bloat to my application.

@brendonparker
Copy link

This looks like a duplicate of #903

@jzabroski
Copy link
Collaborator

I'm working this month on 4.0 for the first time in over a year. Hopefully that's the solution.

@jzabroski jzabroski added this to the 4.0.0 milestone Sep 14, 2021
@mattbrailsford
Copy link
Contributor

Submitted PR #1600 to resolve this

@jzabroski
Copy link
Collaborator

Closing as dupe of #903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants