Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GalleryPanel should inherit from VirtualizingStackPanel instead of Panel #142

Closed
batzen opened this issue Jul 23, 2015 · 1 comment
Closed
Assignees
Milestone

Comments

@batzen
Copy link
Member

batzen commented Jul 23, 2015

The GalleryPanel is used as ItemsHost in the following controls:

  • ComboBox
  • Gallery
  • InRibbonGallery

As we can't just replace the used GalleryPanel with a regular VirtualizingStackPanel as this would remove the grouping etc. we should change the inheritance of GalleryPanel from Panel to VirtualizingStackPanel.

GalleryPanel always had an "Orientation"-Property which was ignored. By changing inheritance to VirtualizingStackPanel it finally gets used.

And the best benefit we get is virtualization. The ComboBox was slow like hell without it taking nearly 4 seconds to show 5000 items on my machine (Core i7 2700k).

I am not sure if I should consider this a breaking change as no external contract is broken except that ItemContainerGenerator can't be set anymore and I don't think anyone was using the GalleryPanel themselves.

@GeertvanHorrik
As you are one of the main consumers of this library, what do you think about this being a breaking change or not?

@batzen batzen self-assigned this Jul 23, 2015
@batzen batzen added this to the Next milestone Jul 23, 2015
@GeertvanHorrik
Copy link
Contributor

Thanks for including me into the discussion. It doesn't look like a breaking change for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants