Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System wide font settings. #31

Merged
merged 9 commits into from
Dec 4, 2014
Merged

System wide font settings. #31

merged 9 commits into from
Dec 4, 2014

Conversation

yakiro-nvg
Copy link

No description provided.

@yakiro-nvg yakiro-nvg changed the title #28, fix font and size of MenuItem, StatusBarMenuItem and RibbonTabItem. #28, System wide font settings. Dec 1, 2014
@yakiro-nvg yakiro-nvg changed the title #28, System wide font settings. System wide font settings. Dec 1, 2014
@batzen
Copy link
Member

batzen commented Dec 1, 2014

While your fixes regarding height restriction might be correct, the direct references to MenuFontSizeKey etc. won't be accepted, as we would have to add this to every control contained in the ribbon if we would follow your path. In fact the Microsoft Ribbon just sets this at the Ribbon level so every control inherits that setting. Please have a look at the generic.xaml contained in the assembly System.Windows.Controls.Ribbon to see where FontSize is used there.

@yakiro-nvg
Copy link
Author

Sure, I have fixed it.

The GUI now break on large font size, because the height of ribbon controls mostly be hard-coded. Still working on it.

Another small issue: DynamicResource binding to SystemsFont now not working with Backstage, so changing of SystemsFont while app still running has no effect. I have no ideal about this problem, it still work well with other ribbon controls.

batzen added a commit that referenced this pull request Dec 4, 2014
System wide font settings.
@batzen batzen merged commit d6dd9c2 into fluentribbon:master Dec 4, 2014
@batzen
Copy link
Member

batzen commented Dec 4, 2014

Thanks for contributing. There is still some work that has to be done to make your changes work perfectly (groups are not resized etc.) but it's better than before. ;-)

@batzen batzen added this to the 3.2.0 milestone Dec 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants