"Auto" size for ribbon group box header to support custom font sizes #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batzen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently implementing themes in our app and I found out that the group box name in the ribbon has a hard-coded height of 17, which is a problem if you increase the overall font-size or change to a larger font.
Changing that to "Auto" did not cause any problems as far as I could see, but makes it possible to increase the font-size without the need to overwrite the control-template on our side (which is what we do at the moment). This makes the following possible - a little crazy just to show of ;-):
==>
All other sizes could be adapted with inherited styles and just setting sizes to "Auto" or values calculated out of the font-size (like
ContentHeightof the ribbon). If someone else wants to support this please send me a message and I'll collect all places I needed to adapt.