Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConvertToSnakeCase - Make compatible with Illuminate TransformsRequest #140

Open
dshannon-ifs opened this issue Aug 12, 2019 · 1 comment

Comments

@dshannon-ifs
Copy link

Hello,

Use of ConvertToSnakeCase (laravel 5.8) throws an error "Declaration of Flugg\Responder\Http\Middleware\ConvertToSnakeCase::cleanArray(array $data) should be compatible with Illuminate\Foundation\Http\Middleware\TransformsRequest::cleanArray(array $data, $keyPrefix = '')".

To resolve method should be declared:

protected function cleanArray(array $data, $keyPrefix = '')

@flugg
Copy link
Owner

flugg commented Aug 27, 2019

Oh, thanks for letting me know. Seems like there was a breaking change with the signature at some point. I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants