Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize error format (Serializer for Errors) #47

Closed
ductiletoaster opened this issue Jul 12, 2017 · 9 comments
Closed

Customize error format (Serializer for Errors) #47

ductiletoaster opened this issue Jul 12, 2017 · 9 comments

Comments

@ductiletoaster
Copy link
Contributor

One issue I have had is that my team is responsible for integrating with some services that use a slightly different error response body. We would like to maintain a standard across all of our services and so having a way to easily define the format of the ErrorResponse would be amazing.

@flugg
Copy link
Owner

flugg commented Jul 12, 2017

You might be happy to know version 2, being released within days, includes a concept for error serializers for customizing it exactly the way you want :)

@ductiletoaster
Copy link
Contributor Author

Nice! Will this newest version be compatible with the same versions of laravel/lumen? Also anyway we can checkout the dev release prior to official release? I had made contributions in the past and I'd love to continue to help where I can! :)

@flugg
Copy link
Owner

flugg commented Jul 12, 2017

Yeah, the plan is to keep the same version requirements. I started a new rewrite after the current dev branch was created, so that's not currently up to date. However, I can push it all up on a new branch if you want to take a look. It's not quite ready to be used in production yet though, but it's almost there! All feedback and help is definitely highly appreciated :)

@ductiletoaster
Copy link
Contributor Author

That sounds great! Going to close this ticket unless you want to keep it open until release?

@flugg
Copy link
Owner

flugg commented Jul 12, 2017

Made a new "v2" branch located here: https://github.com/flugger/laravel-responder/tree/v2

The documentation has also been rewritten (but it's not complete). Lemme know what you think!

And sure, let's keep it open until the version is released.

@ductiletoaster
Copy link
Contributor Author

Awesome! Took a quick glimpse and it all looks great! Would you like me to do Pull Requests for feedback? or just comment back here?

@flugg
Copy link
Owner

flugg commented Jul 12, 2017

Thanks, and either is fine really! If you have certain things you want to discuss in more detail it might be easier to use another platform. Are you a member of the Larachat Slack channel by any chance?

@ductiletoaster
Copy link
Contributor Author

Just join under ductiletoaster

@flugg
Copy link
Owner

flugg commented Aug 8, 2017

Version 2 has been released and introduces the concept of error serializers.

@flugg flugg closed this as completed Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants