Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player does not start to count the inactive time... #786

Open
drsheep404 opened this issue Dec 14, 2023 · 2 comments
Open

Player does not start to count the inactive time... #786

drsheep404 opened this issue Dec 14, 2023 · 2 comments
Labels

Comments

@drsheep404
Copy link

drsheep404 commented Dec 14, 2023

Version: 3.28.0
The player shows the controls at mouseenter too.

t.domRef.wrapper.addEventListener('mouseenter', t.showControlBar, !1)

(t.domRef.wrapper is the container <div> of the <video>.)

However, mouseenter may be fired after temporarily shrunken after clicking the skip button (pre roll ads). Therefore, the player does not start to count the inactive time so that nobody hides the controls automatically.
That in effect the yellow "url" bar at bottom never disappear showing video file url permanently.

Actual results:
Bottom left address bar does not disappear

Expected results:
Bottom left address bar should disappear when going to full screen mode.

@drsheep404
Copy link
Author

As far as I've investigated, that's caused by that userInactive dispatcher is not set properly when the `` element is resized and it's shown by the mouseenter listener.

When an element under the mouse cursor is changed, browsers will dispatch mouseover and mouseout events on the topmost element and the last mouse-over element, but won't dispatch mousemove. Therefore, userActivityChecker cannot set the timer.

@sergiomcsousa
Copy link

An internal ticket was created to take care of this issue. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants