Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't use generatePermalink in eleventyComputed block #201

Merged

Conversation

greatislander
Copy link
Contributor

generatePermalink needs to be used outside of the eleventyComputed block, see Computed data:

It is important to note that Computed Data is computed right before templates are rendered. Therefore Computed Data cannot be used to modify the special data properties used to configure templates (e.g. layout, pagination, tags etc.).

@greatislander greatislander modified the milestone: 2.4.0 Aug 14, 2023
@greatislander greatislander linked an issue Aug 14, 2023 that may be closed by this pull request
@greatislander greatislander added the bug Something isn't working label Aug 14, 2023
@greatislander greatislander self-assigned this Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #201 (69ec0fe) into main (c7403ac) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #201   +/-   ##
=======================================
  Coverage   97.05%   97.05%           
=======================================
  Files          14       14           
  Lines         679      679           
=======================================
  Hits          659      659           
  Misses         20       20           
Files Changed Coverage Δ
src/utils/generate-permalink.js 100.00% <100.00%> (ø)

@greatislander greatislander merged commit 2d4c1cf into fluid-project:main Aug 14, 2023
5 checks passed
@greatislander greatislander deleted the feat/remove-pagination-logic branch August 14, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove pagination logic from eleventyComputed
2 participants