Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve issue with pagination URLs #8

Merged
merged 5 commits into from
Aug 15, 2023

Conversation

greatislander
Copy link
Contributor

@greatislander greatislander commented Aug 11, 2023

  • This pull request has been linted by running npm run lint without errors
  • This pull request has been tested by running npm run start and reviewing affected routes
  • This pull request has been built by running npm run build without errors
  • This isn't a duplicate of an existing pull request

Description

This PR resolves an issue where the links generated by Eleventy's pagination plugin did not use the computed permalink from pages.11tydata.js. It also improves the accessibility of the pagination component.

Steps to test

  1. Run npm start.

Expected behaviour: Pagination works as expected.

Additional information

See also: fluid-project/trivet#353

Related issues

Not applicable.

@greatislander greatislander added the bug Something isn't working label Aug 11, 2023
@greatislander greatislander added this to the 1.0.1 milestone Aug 11, 2023
@greatislander greatislander self-assigned this Aug 11, 2023
@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for trivet-monolingual ready!

Name Link
🔨 Latest commit 861def9
🔍 Latest deploy log https://app.netlify.com/sites/trivet-monolingual/deploys/64da7da99228bf00082fc603
😎 Deploy Preview https://deploy-preview-8--trivet-monolingual.netlify.app/posts
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@greatislander greatislander enabled auto-merge (squash) August 14, 2023 14:32
@greatislander greatislander merged commit 47d4a35 into fluid-project:main Aug 15, 2023
8 checks passed
@greatislander greatislander deleted the fix/pagination branch January 8, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants