Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spoolman): remember spool selection dialog sort key/order #1305

Merged
merged 3 commits into from Jan 11, 2024
Merged

feat(spoolman): remember spool selection dialog sort key/order #1305

merged 3 commits into from Jan 11, 2024

Conversation

matmen
Copy link
Member

@matmen matmen commented Jan 10, 2024

Closes #1181

@matmen
feat(spoolman): remember spool selection dialog sort key/order
2e95e4e 
Signed-off-by: Mathis Mensing <github@matmen.dev>
@matmen matmen added the FR - Enhancement New feature or request label Jan 10, 2024
@matmen matmen marked this pull request as draft January 10, 2024 21:35
@matmen
fix: save full object to state
5e899bf 
prevents errors when there's no selectionDialogSortOrder key in the state

Signed-off-by: Mathis Mensing <github@matmen.dev>
@matmen matmen marked this pull request as ready for review January 10, 2024 21:51
@pedrolamas
refactor: set default state
015a419 
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
pedrolamas
pedrolamas approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@pedrolamas pedrolamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved the default sort to the default initial state so it is more consistent with the rest.

The rest is all good!

@pedrolamas pedrolamas added this to the 1.27.2 milestone Jan 11, 2024
@matmen matmen merged commit 3843701 into fluidd-core:develop Jan 11, 2024
4 checks passed
@matmen matmen deleted the feat/spoolman-store-sort-order branch January 11, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrolamas pedrolamas pedrolamas approved these changes

Assignees
No one assigned
Labels
FR - Enhancement New feature or request
Projects
None yet
Milestone
1.28
Development

Successfully merging this pull request may close these issues.

Setting for default Spoolman sort order
2 participants
@matmen @pedrolamas