Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spoolman): handle v2 responses, improve connection error handling #1316

Merged
merged 4 commits into from Jan 22, 2024

Conversation

matmen
Copy link
Member

@matmen matmen commented Jan 20, 2024

Adds support for the v2 responses and events proposed in Arksine/moonraker#792

Emits errors via toast notifications (on initial load) and shows a disconnected/out-of-sync state more clearly:
image

Signed-off-by: Mathis Mensing <github@matmen.dev>
@matmen matmen added FR - Enhancement New feature or request Upstream - Moonraker For everything API related labels Jan 20, 2024
@matmen matmen added this to the 1.27.2 milestone Jan 20, 2024
Signed-off-by: Mathis Mensing <github@matmen.dev>
@matmen matmen merged commit cf69359 into fluidd-core:develop Jan 22, 2024
4 checks passed
@matmen matmen deleted the refactor/spoolman-v2 branch January 22, 2024 12:16
@thijstriemstra
Copy link
Contributor

thijstriemstra commented Jan 27, 2024

Shouldn't "it" be a 1.28 version? 1.27.2 sounds like a minor minor update to 1.27.1 @pedrolamas

@pedrolamas
Copy link
Member

Shouldn't "it" be a 1.28 version? 1.27.2 sounds like a minor minor update to 1.27.1 @pedrolamas

Indeed!!

When we release an updated version, we normally create a new patch Milestone just after it so we can start assigning stuff for the next release, and when we see it is getting bigger than a patch release, we just change it to the next minor version - which is what I am about to do now! 🙂

@thijstriemstra
Copy link
Contributor

thanks for the update. It's been quite a while since last release, any ETA for the next @pedrolamas?

@pedrolamas
Copy link
Member

KungFuPandaLiGIF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR - Enhancement New feature or request Upstream - Moonraker For everything API related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants