fix: use Klipper can_extrude by default #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CromFr
force-pushed
the
allow-extrusion-with-negative-temps
branch
from
3e739d9
to
2f7d599
Compare
Signed-off-by: Thibaut CHARLES <CromFr@gmail.com>
CromFr
force-pushed
the
allow-extrusion-with-negative-temps
branch
from
2f7d599
to
579fbbc
Compare
Klipper added `can_extrude` at least 2 years ago, so we should use this property if available and fallback to current behavior otherwise.
pedrolamas
changed the title
pedrolamas
approved these changes
Mar 20, 2024
|
Hi @CromFr, thank you for opening this Pull Request. I've made a few changes as to use the |
|
That's a much better solution indeed ! |
matmen
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current conditions disabled extrusion controls on Fluidd if the klipper min_extrude_temp protection is set to a sub-zero temp.
For some context, I'm working on a ceramic printer, that does not have any heater nor thermistor on the hotend. The quick and easy way to disable any temp-related security on klipper is to set min_extrude_temp to -273.15, so that any temp detected by a connected (or in my case disconnected) thermistor won't prevent the extrusion.
While this works as expected with klipper (sending
G1 E10does extrude), the extrusion controls on fluidd are disabled with this cheeky message:Note: I haven't looked at how min_extrude_temp is fetched by fluidd, maybe a value of 0 has a special meaning (i.e. a default value when undefined / could not be fetched?)