Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FileSystem): remember last sort order #1406

Merged

Conversation

pedrolamas
Copy link
Member

@pedrolamas pedrolamas commented Apr 4, 2024

This will store the last user selected file sort order (per root) and restore it on reload of the page.

I also did a small refactor of the initial set of state.uiSettings to make it a bit more dynamic (we had already forgotten to add a few properties there, this should ensure that is now automatic)

Resolves #1405

@pedrolamas pedrolamas added the FR - Enhancement New feature or request label Apr 4, 2024
@pedrolamas pedrolamas added this to the 1.29.2 milestone Apr 4, 2024
@pedrolamas pedrolamas requested a review from matmen April 4, 2024 10:07
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Copy link
Member

@matmen matmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrolamas pedrolamas merged commit 5cf9a49 into fluidd-core:develop Apr 4, 2024
4 checks passed
@pedrolamas pedrolamas deleted the pedrolamas/file-sort-order branch April 4, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR - Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have the File System cards remember the user selected sort order
2 participants