Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show all fan and pin values as percentages #1418

Merged

Conversation

pedrolamas
Copy link
Member

Ideally, limited scale values in the front-end should be presented as a percentage instead of the Klipper value - that is for config and console purposes.

The changes in this pull request are as follows:

  • non-controllable (read-only) fans and output pins will show "Off" when value is 0, otherwise presents the value on a scale of 0% to 100%.
  • controllable pwm output-pins will always present the value on a scale of 0% to 100%.

Before

image

After

image

Partial test config used for the above:

[heater_fan heater_fan]
pin: PD4
off_below: 0.2
shutdown_speed: 0.0
max_power: 0.6
fan_speed: 0.85

[output_pin test_pwm_pin]
pin: PD7
pwm: True
value: 0.6
scale: 0.8
cycle_time: 0.1

Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
@pedrolamas pedrolamas added FR - Enhancement New feature or request UI - Change All matters related to a significant change in the UI labels Apr 18, 2024
@pedrolamas pedrolamas added this to the 1.29.2 milestone Apr 18, 2024
@pedrolamas pedrolamas requested a review from matmen April 18, 2024 12:08
Copy link
Member

@matmen matmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrolamas pedrolamas merged commit 192ee19 into fluidd-core:develop Apr 18, 2024
5 checks passed
@pedrolamas pedrolamas deleted the pedrolamas/percent-controls branch April 18, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR - Enhancement New feature or request UI - Change All matters related to a significant change in the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants