Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: job card history metadata race condition #668

Merged

Conversation

matmen
Copy link
Member

@matmen matmen commented May 12, 2022

Closes #662

@matmen matmen added the GH - Bug Something isn't working label May 12, 2022
@matmen matmen added this to the 1.18.1 milestone May 12, 2022
@matmen matmen requested a review from pedrolamas May 12, 2022 17:45
@pedrolamas
Copy link
Member

Can't we just force a dispatch from onHistoryList action instead to reset the history on all files?

@matmen
Copy link
Member Author

matmen commented May 13, 2022

The problem is that the file system browser isn't reactive to the history state changing. onHistoryList being dispatched doesn't update the stats in the file browser either.

Signed-off-by: Mathis Mensing <matmen@dreadful.tech>
@matmen matmen force-pushed the fix/jobs-history-meta-racecondition branch from 594b4b2 to 8d62716 Compare May 13, 2022 16:15
@matmen matmen merged commit 5ce0921 into fluidd-core:develop May 15, 2022
@matmen matmen deleted the fix/jobs-history-meta-racecondition branch May 15, 2022 16:39
matmen added a commit to matmen/fluidd that referenced this pull request Jun 27, 2022
Signed-off-by: Mathis Mensing <matmen@dreadful.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GH - Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jobs Does Not Display Print Duration or Total Duration, but History Does
2 participants