Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(style): light theme fixes/improvements #676

Merged
merged 7 commits into from
May 15, 2022

Conversation

matmen
Copy link
Member

@matmen matmen commented May 15, 2022

Closes #673


Screenshots of the new styling (light and dark theme):

image image

image image

image image

image
image

Signed-off-by: Mathis Mensing <matmen@dreadful.tech>
Signed-off-by: Mathis Mensing <matmen@dreadful.tech>
Signed-off-by: Mathis Mensing <matmen@dreadful.tech>
Signed-off-by: Mathis Mensing <matmen@dreadful.tech>
@matmen matmen added GH - Bug Something isn't working UI - QoL Improvements to the UI labels May 15, 2022
@matmen matmen added this to the 1.18.1 milestone May 15, 2022
@matmen matmen requested a review from pedrolamas May 15, 2022 12:44
@pedrolamas
Copy link
Member

For the AppNotificationsMenu, it's easier to just add the light--theme entries:

after this:

  ::v-deep .app-notifications .v-list-item .v-list-item__subtitle.notification-timestamp {
    color: rgba(255, 255, 255, 0.47);
  }

add this:

  .theme--light ::v-deep .app-notifications .v-list-item .v-list-item__subtitle.notification-timestamp {
    color: rgba(0, 0, 0, 0.47);
  }

And after this:

  ::v-deep .app-notifications .v-list-item .v-list-item__subtitle.notification-description {
    font-style: italic;
    color: rgba(255, 255, 255, 0.60);
  }

add this:

  .theme--light ::v-deep .app-notifications .v-list-item .v-list-item__subtitle.notification-description {
    color: rgba(0, 0, 0, 0.60);
  }

matmen and others added 2 commits May 15, 2022 16:22
Signed-off-by: Mathis Mensing <matmen@dreadful.tech>
Co-authored-by: Pedro Lamas <pedrolamas@gmail.com>
Signed-off-by: Mathis Mensing <matmen@dreadful.tech>
@matmen matmen merged commit 1530697 into fluidd-core:develop May 15, 2022
@matmen matmen deleted the fix/light-theme branch May 15, 2022 14:33
matmen added a commit to matmen/fluidd that referenced this pull request Jun 27, 2022
Signed-off-by: Mathis Mensing <matmen@dreadful.tech>
Co-authored-by: Pedro Lamas <pedrolamas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GH - Bug Something isn't working UI - QoL Improvements to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button and test color issues on the white theme
2 participants