Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Feature: Form / ManualField ViewHelper #99

Closed
NamelessCoder opened this issue Mar 29, 2013 · 12 comments
Closed

[REQUEST] Feature: Form / ManualField ViewHelper #99

NamelessCoder opened this issue Mar 29, 2013 · 12 comments

Comments

@NamelessCoder
Copy link
Member

This ViewHelper should do everything a plain input form ViewHelper in Fluid does - but never return a rendered field. It should only register a form field token - see in the abstract form ViewHelper in Fluid examples of 1) getting the resulting name of a form field created in a ViewHelper and 2) registering that name to include it in token HMAC building.

Purpose:

<v:form.manualField property="relatedObjects" />
<input type="hidden" name="tx_ext[scope][object][manualName]" />
<!-- insert super advanced selector for related objects here. Results in perfect HMAC with fully custom field -->
@NamelessCoder
Copy link
Member Author

Correction to propsal: let ViewHelper always return the name of the field. Rename to reflect this.

<input type="hidden" name="{v:form.fieldName(property: 'relatedObjects')}" />

Much smoother and easier to predict result :)

@NamelessCoder
Copy link
Member Author

Could also make sense to add a silent attribute - for example to build HMACs for each <option> in a <select> since options don't have name attributes and HTML comments would be bad...

@bjo3rnf
Copy link
Contributor

bjo3rnf commented Apr 12, 2013

Sorry, I don't get it. Could you please describe what this ViewHelper should do for dummies like me ;) ?

@NamelessCoder
Copy link
Member Author

It would be my pleasure to describe it in more detail - but I hope you can live with it being later today? :)

@bjo3rnf
Copy link
Contributor

bjo3rnf commented Apr 12, 2013

but I hope you can live with it being later today

Abso-effin-lutely ;)

@NamelessCoder
Copy link
Member Author

We did not get around to discussing this one on Friday (was my 2nd item but then I had to leave, had guests coming over) perhaps you have ~15 minutes on IRC today? :)

@bjo3rnf
Copy link
Contributor

bjo3rnf commented Apr 14, 2013

I sure have, but not before tonight. I'll knock.

cedricziel pushed a commit to cedricziel/vhs that referenced this issue Jul 19, 2013
@bjo3rnf
Copy link
Contributor

bjo3rnf commented Aug 6, 2013

ping @NamelessCoder and @cedricziel ;)

@cedricziel
Copy link
Member

Dude what's happening on your drive? Please check the casing of the filename again. Didnt I PR to fix this above? :-)

@bjo3rnf
Copy link
Contributor

bjo3rnf commented Aug 6, 2013

Ehm, yes, that's why it's properly named...? Timewarp is also fixed long time ago (pun)...?

@cedricziel
Copy link
Member

Ehm. WTF is going on GitHub? Maybe it's a layer 8 problem on my side, please dont mind then :-/

cedricziel pushed a commit to cedricziel/vhs that referenced this issue Aug 8, 2013
cedricziel pushed a commit to cedricziel/vhs that referenced this issue Aug 21, 2013
@NamelessCoder
Copy link
Member Author

Under review; closing this feature request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants