Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could most of this factor out? #2

Closed
pfrazee opened this issue Apr 4, 2016 · 1 comment
Closed

Could most of this factor out? #2

pfrazee opened this issue Apr 4, 2016 · 1 comment

Comments

@pfrazee
Copy link

pfrazee commented Apr 4, 2016

I was reading through the implementation and it looks like the only link-specific thing is tied up in the emitter:

function links (doc, emit) {
  emit({source: s, dest: d, rel: r, ts: ts})
}
...
StreamviewLinks(dirname, indexes, links, version)

If this method didnt emit links, but some other extracted data, wouldnt this be pretty general?

@dominictarr
Copy link
Collaborator

this is now the case... should rename, really.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants