Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting variables using dotted paths #22

Closed
madx opened this issue Jun 23, 2020 · 1 comment
Closed

Add support for setting variables using dotted paths #22

madx opened this issue Jun 23, 2020 · 1 comment
Assignees
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@madx
Copy link
Contributor

madx commented Jun 23, 2020

Dotted paths can currently be used only to retrieve a variable's value. The user should be able to also do things like

set("path.to.a.variable", value)
@madx madx added bug Something isn't working enhancement New feature or request labels Jun 23, 2020
@madx madx added this to the 1.0.0 milestone Jun 23, 2020
@madx madx self-assigned this Jun 23, 2020
@madx
Copy link
Contributor Author

madx commented Jun 26, 2020

NO, we shouldn't do this, as we should not encourage using deeply nested items.

We can already update a variable easily, to update a field in an object I believe it's better to have some separate way for updating the object, then use set to update the whole object.

@madx madx closed this as completed Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant