Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching Server side errors to the Form. #18

Closed
ghost opened this issue Jan 17, 2019 · 1 comment
Closed

Matching Server side errors to the Form. #18

ghost opened this issue Jan 17, 2019 · 1 comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Milestone

Comments

@ghost
Copy link

ghost commented Jan 17, 2019

I just tried the example and noticed something..

When you post the form to the server ( or where ever) you have to do some server side validation for cross cutting edge cases & concerns.

  • validate that any data referenced ( like an enum, KV value ) is still in the DB.
  • any business logic checks.

SO what is probably also needed is a standard approach for showing Server side errors relating to a form.

  1. If the error is unrelated to a specific form field ( like a business logic error), then show it at the bottom where the submit button is since that is where the user is visually in the scroll.
  • This should be baked into the Submit Button Widget maybe. Up for debate..
  1. If the error relates to one or more fields, then show the server side error against those fields.
  • once the user has change those fields, the error goes away, allowing the user to try again.

I noticed you have support already for server side errors coming back, but no formal support for how to handle it.
So if we can bake this into the example if would be worthwhile.

Please ask if you have any questions as i have had to deal with this stuff quite a bit on many projects.

@danvick
Copy link
Collaborator

danvick commented Jul 20, 2020

This issue will be handled under #123. v4.0.0-alpha.6 has a fix - feel free to review and give feedback

@danvick danvick added duplicate This issue or pull request already exists enhancement New feature or request and removed help wanted Extra attention is needed labels Jul 20, 2020
@danvick danvick closed this as completed Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant