Skip to content
This repository has been archived by the owner on Jan 27, 2024. It is now read-only.

Web Support #44

Open
VictorUvarov opened this issue Apr 3, 2021 · 24 comments
Open

Web Support #44

VictorUvarov opened this issue Apr 3, 2021 · 24 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@VictorUvarov
Copy link
Contributor

VictorUvarov commented Apr 3, 2021

Apparently Google's libphonenumber is also a JavaScript library. I assume it might also support Flutter web.

@nashfive nashfive added enhancement New feature or request help wanted Extra attention is needed labels May 20, 2021
@deandreamatias
Copy link
Contributor

Maybe this library can help with this

@iamsahilsonawane
Copy link
Member

@nashfive
This is a must-have thing. None of the packages on pub.dev I see for phone number parsing, validation and internationalization. We need to work on this.

I'll be starting to work on this sooner I guess, please let me know if there's work already started?

@nashfive
Copy link
Contributor

nashfive commented Jul 7, 2022

Hi @iamsahilsonawane,

I agree that the web support would be a great addition.

There is indeed an opened (and old) pull request that was implementing this somehow. It has never been merged as it requires thorough testing. Also, the architecture of the plugin itself is old and doesn't follow the modern Flutter standards anymore (platform separation, etc.)

As I am not working with Flutter anymore, I am not providing support anymore for this plugin. I am willing to transfer the ownership to anyone who is willing to take over its development. Let me know if you're interested ?

@deandreamatias
Copy link
Contributor

Hi @nashfive!
Thanks for answer.
Others devs and me start working in a new organization to provide flutter form solutions. You can see discussion about this here.

In one of form solutions (form_builder_phone_field), we use this plugin to build it.

It would be nice transfer this ownership to this organization. We can add @iamsahilsonawane like collaborator if he want

@iamsahilsonawane
Copy link
Member

@nashfive
Thanks for the comment. I would definitely want to take charge of this and was going to study the plugin code to understand if I would be a great fit or not for this plugin.

And as per @deandreamatias 's comment, yes I would be happy to be a part of collaborating with them 👍🏻

@nashfive
Copy link
Contributor

nashfive commented Jul 7, 2022

Hi @deandreamatias

I like the idea! Would it be still possible for users to install/use the phone_number plugin directly without using the form_builder_phone_field package?

@deandreamatias
Copy link
Contributor

@nashfive Yeah yeah, of course. My idea is maintain this repo like currently, separated and like one more dependency of form_builder_phone_field

@iamsahilsonawane
Copy link
Member

Let me know guys when you're ready to do something about transferring the ownership. @deandreamatias I'll be happy to help!

@deandreamatias
Copy link
Contributor

@iamsahilsonawane I sent you a invite to organization 🚀

@nashfive
Copy link
Contributor

nashfive commented Jul 7, 2022

In order to be able to transfer the ownership, I need to be invited to the the Flutter Form Builder Ecosystem organization, as well as its associated pub.dev's publisher.

@deandreamatias
Copy link
Contributor

deandreamatias commented Jul 7, 2022

We don't have a pub.dev publisher associated with this organization yet :(
At moment, all form packages is published by @danvick

@nashfive
Copy link
Contributor

nashfive commented Jul 7, 2022

I've transferred the repo to the organization already.
It seems that I can only transfer the plugin on pub.dev to an existing publisher, and I need to be a member of that publisher as well 🤔

@nashfive
Copy link
Contributor

nashfive commented Jul 7, 2022

@iamsahilsonawane @deandreamatias
While waiting for a valid publisher on your end, I should probably invite you guys in my publisher team so you can publish new versions of the plugin. Is that for with you?
can you provide me the emails you use for pub.dev?

@deandreamatias
Copy link
Contributor

I need discuss with others devs the best solution to create a organization publisher.
My email on pub.dev is deandreamatias@gmail.com. I has my own publisher, I don't know if this is a problem

@iamsahilsonawane
Copy link
Member

I think we should be good with this. Though, I'll let @deandreamatias comment on this one.

Besides, iamsahilsonawane@gmail.com is my email.

@nashfive
Copy link
Contributor

nashfive commented Jul 7, 2022

Ah ok, it's definitely not a problem I think.
I've added you Dean to my publisher. You can even transfer the plugin to yours whenever you see fit.

@iamsahilsonawane
Copy link
Member

Ah ok, it's definitely not a problem I think.
I've added you Dean to my publisher. You can even transfer the plugin to yours whenever you see fit.

Sure thanks 👍

@iamsahilsonawane
Copy link
Member

@deandreamatias Can you please revert back to the email? I've mailed you regarding planning stuff out

@SavvyBud
Copy link

Does this library support web? I keep getting error: MissingPluginException(No implementation found for method parse on channel com.julienvignali/phone_number)

@loic-hamdi
Copy link

Any update?

@iamsahilsonawane
Copy link
Member

I've been very busy lately with some unignorable tasks. It will take a bit of time for me to start on this. If anyone's interested in working on that, pull requests are welcomed. Or if not, I'll work on this in some days.

@deandreamatias I'll need your help in migrating to the federated plugin as soon you're available as well, so we can proceed with working on future updates and platform support without any issues.

@deandreamatias
Copy link
Contributor

I might can help answer some questions and things related to architecture, but I also don't have time to develop this package right now. First I (really) need finish a migration in my personal project, that was starting 9 months ago (melting face emoji)

@loic-hamdi
Copy link

I might can help answer some questions and things related to architecture, but I also don't have time to develop this package right now. First I (really) need finish a migration in my personal project, that was starting 9 months ago (melting face emoji)

How is going the tv-randshow project? :)

@deandreamatias
Copy link
Contributor

@loic-hamdi tv-randshow done. Now I have another project on personal life.
I made a comment about this plugin. Take a look here #102 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Development

No branches or pull requests

6 participants