Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to newer version of Rust #151

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MGlolenstine
Copy link

  • fixed code and made it compile. (There was a lot of errors because 'usize' moved from u64 to u128)
  • cleaned up Markdown documents.
  • updated dependencies

@MGlolenstine
Copy link
Author

All build checks failed because of the rustup problem. I think that the CI configuration should be updated.

@zicklag
Copy link

zicklag commented May 3, 2021

I'm new to flutter and flutter-rs, but here's my experience testing this PR. 🙂

On Ubuntu 20.04, building an app using the winit backend will flash the window quickly before it immediately crashing afterwards. It's not even getting to the winit event loop processing. This happens for me with the flutter demo app release on GitHub, though so that might not be this PR, but something that was already happening with the winit backend. This does fix the winit backend compile problems, though.

flutter_glfw works for me though, other than #155 which definitely existed before this PR.

@tojocky
Copy link

tojocky commented Dec 30, 2021

any chance this to be merged?

@MGlolenstine
Copy link
Author

MGlolenstine commented Dec 30, 2021

@tojocky I think that the CI will have to be fixed first.
Somebody reported that this backend isn't working for them either.
If a library switch is possible, I'd suggest a switch to a more updated RID.

@tojocky
Copy link

tojocky commented Dec 30, 2021

I'd suggest a switch to a more updated RID

it seems to be based on message store exchange, It is safe but it has a cost. I would prefer to have more direct access.

@MGlolenstine
Copy link
Author

You might like the alternative nativeshell, that's been mentioned before over here.

@tojocky
Copy link

tojocky commented Dec 30, 2021

nativeshell looks interesting. I will stick with direct ffi interface

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants