Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current work #24

Closed
rlsutton1 opened this issue Oct 18, 2019 · 3 comments
Closed

Current work #24

rlsutton1 opened this issue Oct 18, 2019 · 3 comments

Comments

@rlsutton1
Copy link
Contributor

Thought I should let you know what I'm working on.

I feel that sip_ua_ helper belongs in the main lib, not the example and that there is far to much of the libs internals exposed through it. So I am currently working on moving it and exposing the information that clients will need without exposing the sip stack internals. I'm also changing the messaging between sip ua helper and the example code to use a simple listener mechanism rather than the event manager.

I found an existing bug and have a fox for it where the Web socket doesn't close when stopping the sip stack.

On Monday I'm intending to fix the dtmf code. It currently breaks after a single dmf digit.

@cloudwebrtc
Copy link
Member

Sorry, I am busy with other things recently and can return to normal schedule next week.

Please refer to https://github.com/cloudwebrtc/dart-sip-ua/projects/1 for the progress of project v1.0.
I have a few thoughts on development work:
1, separate internal events and public events, try to make package:sip_ua/sip_ua.dart export the least public API file.
In the end, there is no SipMessage, Request, and signaling-related classes in the public API, but only some required ua events,, status_code, cause, text message, error reason, MediaStream, etc.
2. Discuss whether SIPUAHelper can be merged into lib, which makes it easier to develop UI with flutter.
3, as mentioned in projects v1.0, we need to conduct interactive tests (registration, call, DTMF, hold, re-invite, update, etc.) on some common open-source sip server.
4, for some of the necessary configuration APIs for export, for example, Authentication User, stun/turn server.

@rlsutton1
Copy link
Contributor Author

If you wish to see what I've been working on with regard to Sip_ua_helper, have a look at https://github.com/noojee/dart-sip-ua

Otherwise, once the outstanding PR's are merged I'll be able to make a clean PR for these changes and we can review it then.

@cloudwebrtc
Copy link
Member

I looked at the differences in your master repository, very good, exactly what I want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants