enable Material 3 on adaptive_app codelab code #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @khanhnwin |
|
@miquelbeltran Can you please grab screenshots of the app before and after? It'll make it easier for @khanhnwin to judge if there are any UX breakages we need to dive into |
|
Yep, I will do that |
|
@domesticmouse @khanhnwin the PR description has been updated with the screenshots |
domesticmouse
approved these changes
Jan 9, 2023
|
Next step, update the codelab content =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work to enable Material 3 on all codelabs and samples.
Initial work done by setting
useMaterial3: trueon the ThemeData creation.Further work needs to be done, updating the codelab code and screenshots. I already have access to the Adaptive App's Flutter codelab doc, so I can update it once this PR is approved.
Before Material 3
With Material 3
Pre-launch Checklist
///). <-- pendingIf you need help, consider asking for advice on the #hackers-devrel channel on Discord.