Update this repo to use package:lints

[devoncarew]

Update this repo to use package:lints; done as several commits for easier review.

Note that dart fix was able to address many of the issues (~100). Below are the ones that remained - several were then addressed by hand:

Analyzing flutter-github-scripts.dart... 1.2s

   info • bin/enumerate_team_members.dart:67:11 • DO use curly braces for all flow control structures. • curly_braces_in_flow_control_structures
   info • bin/enumerate_team_members.dart:82:9 • DO use curly braces for all flow control structures. • curly_braces_in_flow_control_structures
   info • bin/enumerate_team_members.dart:122:9 • Prefer typing uninitialized variables and fields. • prefer_typing_uninitialized_variables
   info • bin/enumerate_team_members.dart:125:17 • Avoid empty catch blocks. • empty_catches
   info • bin/enumerate_team_members.dart:127:9 • Prefer typing uninitialized variables and fields. • prefer_typing_uninitialized_variables
   info • bin/enumerate_team_members.dart:131:17 • Avoid empty catch blocks. • empty_catches
   info • bin/enumerate_team_members.dart:155:9 • Prefer typing uninitialized variables and fields. • prefer_typing_uninitialized_variables
   info • bin/enumerate_team_members.dart:158:17 • Avoid empty catch blocks. • empty_catches
   info • bin/enumerate_team_members.dart:160:9 • Prefer typing uninitialized variables and fields. • prefer_typing_uninitialized_variables
   info • bin/enumerate_team_members.dart:163:17 • Avoid empty catch blocks. • empty_catches
   info • bin/flutterfire_all_closed_over_time.dart:80:9 • DO use curly braces for all flow control structures. • curly_braces_in_flow_control_structures
   info • bin/flutterfire_closed_over_time.dart:109:9 • DO use curly braces for all flow control structures. • curly_braces_in_flow_control_structures
   info • bin/notable-contributors.dart:1:1 • Name source files using `lowercase_with_underscores`. • file_names
   info • bin/notable-contributors.dart:153:9 • DO use curly braces for all flow control structures. • curly_braces_in_flow_control_structures
   info • bin/priority_over_time.dart:109:9 • DO use curly braces for all flow control structures. • curly_braces_in_flow_control_structures
   info • bin/who_is_doing_what.dart:227:11 • Equality operator `==` invocation with references of unrelated types. • unrelated_type_equality_checks
   info • bin/widw-server.dart:1:1 • Name source files using `lowercase_with_underscores`. • file_names
   info • lib/github_datatypes.dart:128:11 • Equality operator `==` invocation with references of unrelated types. • unrelated_type_equality_checks
   info • lib/github_datatypes.dart:150:9 • DO use curly braces for all flow control structures. • curly_braces_in_flow_control_structures
   info • lib/github_datatypes.dart:603:37 • Equality operator `==` invocation with references of unrelated types. • unrelated_type_equality_checks
   info • lib/github_datatypes.dart:733:9 • DO use curly braces for all flow control structures. • curly_braces_in_flow_control_structures
   info • lib/github_datatypes.dart:763:9 • DO use curly braces for all flow control structures. • curly_braces_in_flow_control_structures
   info • lib/github_datatypes.dart:932:9 • DO use curly braces for all flow control structures. • curly_braces_in_flow_control_structures
   info • lib/github_datatypes.dart:963:9 • DO use curly braces for all flow control structures. • curly_braces_in_flow_control_structures
   info • lib/github_datatypes.dart:1107:9 • DO use curly braces for all flow control structures. • curly_braces_in_flow_control_structures
   info • lib/github_datatypes.dart:1140:9 • DO use curly braces for all flow control structures. • curly_braces_in_flow_control_structures
   info • lib/github_datatypes.dart:1759:9 • DO use curly braces for all flow control structures. • curly_braces_in_flow_control_structures
   info • lib/github_datatypes.dart:1783:9 • DO use curly braces for all flow control structures. • curly_braces_in_flow_control_structures
   info • lib/github_queries.dart:155:25 • Name non-constant identifiers using lowerCamelCase. • non_constant_identifier_names
   info • lib/github_queries.dart:497:9 • Name non-constant identifiers using lowerCamelCase. • non_constant_identifier_names
   info • lib/github_queries.dart:510:9 • Name non-constant identifiers using lowerCamelCase. • non_constant_identifier_names
   info • lib/github_queries.dart:520:9 • Name non-constant identifiers using lowerCamelCase. • non_constant_identifier_names

32 issues found.

Three lints were ignored; one - unrelated_type_equality_checks - has 3 violations. They should likely all be investigated as they're almost certainly bugs. I don't know if the scripts they're occurring in are used anymore; if not, we should just delete the scripts.

[devoncarew]

@pq - can you review this?

[pq]

👍