New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contributing to the Flutter plugin using Windows #5331
Comments
You are missing some symbolic links.
These should all be symlinks to the same-named directory in the root directory. You probably have more missing symlinks. You are possibly the first person to attempt working on the plugin using Windows, so there may be more issues down the road. However, if you want to continue just keep asking questions. It would be great to get PRs from someone using Windows! Our directory structure is odd, for historical reasons. We started the project using *.iml files to define modules. When Kotlin adoption increased, we realized we needed a Gradle model in order to compile Kotlin. That's why we have the symlinks. Building the plugin and running unit tests require the Gradle model. You might have better results if you try opening as a legacy project rather than as a Gradle project. I forget the details but I think if you use One more thing. I just updated CONTRIBUTING.md today, so make sure you have the latest. The latest includes a mention of IntelliJ 2020.3 and Java 11, neither of which were in the previous version. I'd recommend updating all your software to the latest versions, too. I'll leave this open so you have a single place to check for questions. |
Hello @stevemessick, Thank you for providing the solution. Also, I have updated to latest versions for IntelliJ (v203.7717.56) & Java (v11.0.10) As you mentioned, I opened the project as a Now, I was working on the Running plugin tests section. Specifically on the Unit Testing part. I know that these tests do not currently run on Windows. But, I would be happy to provide my contribution in including them on Windows. Following are the queries:
In the above step, I didn't see any
(from CONRIBUTING.md) In this step, what does ~/flutter-intellij/bin (The bin folder under repository)
(from CONRIBUTING.md) In this step, does
I was not able to run this command on |
It would be great to get the unit tests running on Windows. We have made a couple attempts to run them on various CI frameworks but the errors are too time-consuming to debug in batch mode.
Yes. Our instructions need to be updated. This whole section is wrong. You should not need to modify templates. The run config is already defined, checked into the github repo. Just select the run config named "Flutter Tests (unit)". You can use the Copy Configuration button to duplicate it if you want to change it to run a subset of tests. (Pardon me if I'm stating the obvious.) Our tests seem to be out of date for running in IntelliJ. I just tried and got lots of failures that look like configuration problems. We generally run the unit tests on the github bots, when we create a PR or merge one. Those work. Those are run via command line.
Change For you to be able to run unit tests from the command line you will need to resolve the Gradle errors. All the symbolic links will be required. Here is the full list: The question I have is, why did the symbolic links not get created for you? We've onboarded several people since the links were added and have had not problems. |
I pretty much got it. Also, talking about symbolic links, I have appended the presence of them in my system on each line in the same txt file. So, I think symbolic links did get generated. |
The We're back to the beginning. I wonder if Gradle is not able to use symbolic links on Windows?
You have the symlinks, so that's not the problem. Is there a more recent version of Gradle available? Are you using the |
The gradle version is the latest stable version Also, I tried running .\gradlew (Click Here)
To get more details, I ran: .\gradlew --warning-mode all (Click here)
So, I changed .\gradlew --warning-mode all (Click here)
Also ran .\gradlew --info (Click here)
|
It looks like symlinks are a problem for Gradle. You might try some of the suggestions mentioned in this issue:
I'm not a Windows expert so I don't have suggestions other than what I see on the web. I saw a reference to something called a "directory junction" that might be related. |
I used all the JDKs from 13 to 16. All were generating error
For Java 15 & 16, I am getting this error:
I tried changing
I have switched Windows to Developer Mode.
Yes, I use |
Fixed in #5545 |
I was following the CONTRIBUTING.md in order to start contributing to the flutter plugin in Intellij IDEA.
I was able to follow all steps before getting gradle build error at:
step from CONTRIBUTING.md.
Here's the error: (Click Here)
Version info
> flutter doctor -v
The text was updated successfully, but these errors were encountered: