Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gis_web] Adds id.renderButton JS-interop. #3011

Merged
merged 11 commits into from Jan 10, 2023
Merged

[gis_web] Adds id.renderButton JS-interop. #3011

merged 11 commits into from Jan 10, 2023

Conversation

ditman
Copy link
Member

@ditman ditman commented Dec 30, 2022

This PR:

  • Adds renderButton API to id.dart.
  • Breaking Change: Makes JS-interop API more dart2wasm-friendly.
    • Removes external getters for function types
    • Introduces an external getter for the whole libraries instead.
    • Updates README.md with the new way of importing the desired libraries.
  • Adds tests to the oauth2 side of the JS-interop layer.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman ditman requested a review from kevmoo December 30, 2022 01:32
@ditman ditman changed the title [gis_web] Add id.renderButton JS-interop. [gis_web] Adds id.renderButton JS-interop. Jan 3, 2023
@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 10, 2023
@auto-submit auto-submit bot merged commit b6fe67e into flutter:main Jan 10, 2023
@ditman ditman deleted the add-button-api branch January 10, 2023 22:53
Maatteogekko pushed a commit to Maatteogekko/packages that referenced this pull request Feb 4, 2023
@ditman @Maatteogekko
[gis_web] Adds id.renderButton JS-interop. (flutter#3011)
9951c52 
* [gis_web] Adds id.renderButton API.

* Modernizes JS-interop so it's more compliant with dart2wasm.
* Updates examples, tests and docs.
* Bumps major version.

* Add the GsiButtonDataExtension class.

* Make oauth2 library more dart2wasm friendly.

* Reimplement hasGrantedA[ny|ll]Scopes in Dart.

* Fix oauth example.

* Added troubleshooting section to README.

* Add happy case tests for the oauth flow.

* Fix typo in config constructors.

* dart format

* Add some error handling to the library

* Add previously_granted_scopes field to overridable token config.

Make scopes a List of Strings in the hasGranted[Any|All]Scopes method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevmoo kevmoo kevmoo approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
2 participants
@ditman @kevmoo