This repository has been archived by the owner on Aug 14, 2023. It is now read-only.
feat: add sparky bumpers #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RuiMiguel
requested review from
erickzanardo,
alestiago and
allisonryan0002
as code owners
|
Looks like the tracing is a bit off. Do you plan to fix it in this PR? |
erickzanardo
approved these changes
Apr 6, 2022
@RuiMiguel let me know if any dimensions are needed from the designs |
yeah, they aren't in this PR. I will change them. Thanks! |
you're right. Let me update the video with last changes |
allisonryan0002
approved these changes
Apr 6, 2022
packages/pinball_components/lib/src/components/sparky_bumper.dart
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SparkyBumpertopinball_componentsSparkyBumperSparkyBumperto sandboxScreen.Recording.2022-04-06.at.15.43.30.mov
Type of Change